Merge pull request #33 from Permissionless-Software-Foundation/ct-unstable

fix(JWT): Added env var to enable/disable JWT retrieval at startup

.gitignore

@@ -68,5 +68,6 @@ ipfsdata
 ipfs-service-provider.sh
 start-bch-wallet-service.sh
 data/
+run-dev.sh
 
 !README.md

bin/server.js

@@ -100,6 +100,13 @@ class Server {
       // Attach the other IPFS controllers
       await controllers.attachControllers(app)
 
+      // ipfs-coord has a memory leak. This app shuts down after 8 hours. It
+      // expects to be run by Docker or pm2, which can automatically restart
+      // the app.
+      setTimeout(function () {
+        process.exit(0)
+      }, 60000 * 60 * 8)
+
       return app
     } catch (err) {
       console.error('Could not start server. Error: ', err)

config/env/common.js

@@ -13,6 +13,8 @@ const ipfsCoordName = process.env.COORD_NAME
   ? process.env.COORD_NAME
   : 'ipfs-bch-wallet-service'
 
+console.log('GET_JWT_AT_STARTUP: ', process.env.GET_JWT_AT_STARTUP)
+
 module.exports = {
   // Configure TCP port.
   port: process.env.PORT || 5001,
@@ -32,7 +34,7 @@ module.exports = {
     : 'emailpassword',
 
   // FullStack.cash account information, used for automatic JWT handling.
-  getJwtAtStartup: false,
+  getJwtAtStartup: process.env.GET_JWT_AT_STARTUP ? true : false,
   authServer: process.env.AUTHSERVER
     ? process.env.AUTHSERVER
     : 'https://auth.fullstack.cash',

production/docker/start-production.sh

@@ -7,7 +7,7 @@
 export MNEMONIC="olive two muscle bottom coral ancient wait legend bronze useful process session"
 
 # The human readable name this IPFS node identifies as.
-export COORD_NAME=ipfs-service-provider-generic
+export COORD_NAME=bch-wallet-service-generic
 
 # Allow this node to function as a circuit relay. It must not be behind a firewall.
 #export ENABLE_CIRCUIT_RELAY=true
@@ -22,6 +22,7 @@ export DEBUG_LEVEL=1
 export DBURL=mongodb://172.17.0.1:5555/ipfs-service-prod
 
 # Customize these environment variables for your own installation.
+export GET_JWT_AT_STARTUP=1
 export AUTHSERVER=https://auth.fullstack.cash
 export APISERVER=https://api.fullstack.cash/v5/
 export FULLSTACKLOGIN=demo@demo.com

src/adapters/ipfs/index.js

@@ -47,10 +47,16 @@ class IPFS {
     } catch (err) {
       console.error('Error in adapters/ipfs/index.js/start()')
 
-      // If error is due to a lock file issue. Kill the process, so that
-      // Docker or pm2 has a chance to restart the service.
-      if (err.message.includes('Lock already being held')) {
-        process.exit(1)
+      // If we are not in a test environment.
+      if (process.env.SVC_ENV !== 'test') {
+        // If error is due to a lock file issue. Kill the process, so that
+        // Docker or pm2 has a chance to restart the service.
+        if (err.message.includes('Lock already being held')) {
+          console.log(
+            'Lock file issue with IPFS. Shutting down so that process manager can restart app.'
+          )
+          process.exit(1)
+        }
       }
 
       throw err

src/adapters/ipfs/ipfs.js

@@ -2,6 +2,10 @@
   Clean Architecture Adapter for IPFS.
   This library deals with IPFS so that the apps business logic doesn't need
   to have any specific knowledge of the js-ipfs library.
+
+  TODO: Add the external IP address to the list of multiaddrs advertised by
+  this node. See this GitHub Issue for details:
+  https://github.com/Permissionless-Software-Foundation/ipfs-service-provider/issues/38
 */
 
 // Global npm libraries

src/controllers/index.js

@@ -26,18 +26,9 @@ class Controllers {
   }
 
   async attachControllers (app) {
-    // Get a JWT token and instantiate bch-js with it. Then pass that instance
-    // to all the rest of the apps controllers and adapters.
-    await this.adapters.fullStackJwt.getJWT()
-    // Instantiate bch-js with the JWT token, and overwrite the placeholder for bch-js.
-    this.adapters.bchjs = await this.adapters.fullStackJwt.instanceBchjs()
-
     // Wait for any startup processes to complete for the Adapters libraries.
     await this.adapters.start()
 
-    // Attach the REST controllers to the Koa app.
-    // this.attachRESTControllers(app)
-
     this.attachRPCControllers()
   }
 

test/unit/controllers/controllers.unit.js

@@ -45,9 +45,7 @@ describe('#Controllers', () => {
     it('should catch and throw errors', async () => {
       try {
         // Force an error
-        sandbox
-          .stub(uut.adapters.fullStackJwt, 'getJWT')
-          .rejects(new Error('test error'))
+        sandbox.stub(uut.adapters, 'start').rejects(new Error('test error'))
 
         const app = {
           use: () => {}