Merge pull request #168 from Permissionless-Software-Foundation/ct-unstable

fix(getRawTransaction): Fixing integration test

src/slp/utils.js

@@ -1588,25 +1588,31 @@ class Utils {
       // Note: validateTxid3() has the same output as validateTxid().
       // validateTxid2() uses slp-validate, which has a different output format.
 
-      // Validate against the whitelist SLPDB first.
-      const whitelistResult = await this.validateTxid3(txid, usrObj)
-      // console.log(
-      //   `whitelist-SLPDB for ${txid}: ${JSON.stringify(
-      //     whitelistResult,
-      //     null,
-      //     2
-      //   )}`
-      // )
+      // If the whitelist SLPDB is having issues, the try/catch will skip it
+      // and continue execution.
+      try {
+        // Validate against the whitelist SLPDB first.
+        const whitelistResult = await this.validateTxid3(txid, usrObj)
+        // console.log(
+        //   `whitelist-SLPDB for ${txid}: ${JSON.stringify(
+        //     whitelistResult,
+        //     null,
+        //     2
+        //   )}`
+        // )
 
-      // Safely retrieve the returned value.
-      if (whitelistResult[0] !== null) isValid = whitelistResult[0].valid
+        // Safely retrieve the returned value.
+        if (whitelistResult[0] !== null) isValid = whitelistResult[0].valid
 
-      // Exit if isValid is not null.
-      if (isValid !== null) {
-        // Save to the cache.
-        cachedTxValidation[txid] = isValid
+        // Exit if isValid is not null.
+        if (isValid !== null) {
+          // Save to the cache.
+          cachedTxValidation[txid] = isValid
 
-        return isValid
+          return isValid
+        }
+      } catch {
+        /* exit quietly */
       }
 
       // Try the general SLPDB, if the whitelist returned null.
@@ -1858,6 +1864,8 @@ class Utils {
 
       return response.data
     } catch (error) {
+      console.log('Error in hydrateUtxos(): ', error)
+
       if (error.response && error.response.data) {
         throw new Error(JSON.stringify(error.response.data, null, 2))
       }

test/integration/blockchain.js

@@ -22,7 +22,7 @@ util.inspect.defaultOptions = {
 
 describe('#blockchain', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#getBestBlockHash', () => {

test/integration/chains/abc/rawtransaction.js

@@ -20,7 +20,7 @@ util.inspect.defaultOptions = {
 
 describe('#rawtransaction', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   /*

test/integration/chains/abc/slp.js

@@ -25,7 +25,7 @@ describe('#SLP', () => {
 
   beforeEach(async () => {
     // Introduce a delay so that the BVT doesn't trip the rate limits.
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
 
     bchjs = new BCHJS({ restURL: process.env.RESTURL })
   })

test/integration/chains/abc/utxo-integration.js

@@ -11,7 +11,7 @@ describe('#UTXO', () => {
   beforeEach(async () => {
     // sandbox = sinon.createSandbox()
 
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#get', () => {

test/integration/chains/testnet/blockchain.js

@@ -29,7 +29,7 @@ util.inspect.defaultOptions = {
 
 describe('#blockchain', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#getBestBlockHash', () => {

test/integration/chains/testnet/control.js

@@ -14,7 +14,7 @@ const bchjs = new BCHJS({ restURL: RESTURL, apiToken: process.env.BCHJSTOKEN })
 
 describe('#control', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#getNetworkInfo', () => {

test/integration/chains/testnet/electrumx.js

@@ -16,7 +16,7 @@ describe('#ElectrumX', () => {
   beforeEach(async () => {
     sandbox = sinon.createSandbox()
 
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   afterEach(() => sandbox.restore())

test/integration/chains/testnet/ninsight.js

@@ -9,7 +9,7 @@ describe('#Ninsight', () => {
   let sandbox
 
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
 
     sandbox = sinon.createSandbox()
   })

test/integration/chains/testnet/rawtransaction.js

@@ -27,7 +27,7 @@ util.inspect.defaultOptions = {
 
 describe('#rawtransaction', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#decodeRawTransaction', () => {

test/integration/chains/testnet/slp.js

@@ -25,7 +25,7 @@ util.inspect.defaultOptions = {
 describe('#SLP', () => {
   beforeEach(async () => {
     // Introduce a delay so that the BVT doesn't trip the rate limits.
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#util', () => {

test/integration/chains/testnet/util.js

@@ -25,7 +25,7 @@ util.inspect.defaultOptions = {
 
 describe('#util', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#validateAddress', () => {

test/integration/control.js

@@ -9,7 +9,7 @@ const bchjs = new BCHJS()
 
 describe('#control', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#getNetworkInfo', () => {

test/integration/electrumx.js

@@ -11,7 +11,7 @@ describe('#ElectrumX', () => {
   beforeEach(async () => {
     sandbox = sinon.createSandbox()
 
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   afterEach(() => sandbox.restore())

test/integration/encryption.js

@@ -5,7 +5,7 @@ const bchjs = new BCHJS()
 
 describe('#Encryption', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#getPubKey', () => {

test/integration/ninsight.js

@@ -11,7 +11,7 @@ describe('#Ninsight', () => {
   beforeEach(async () => {
     sandbox = sinon.createSandbox()
 
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   afterEach(() => sandbox.restore())

test/integration/price.js

@@ -4,7 +4,7 @@ const bchjs = new BCHJS()
 
 describe('#price', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#current', () => {

test/integration/rawtransaction.js

@@ -19,7 +19,7 @@ util.inspect.defaultOptions = {
 
 describe('#rawtransaction', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#decodeRawTransaction', () => {
@@ -191,8 +191,7 @@ describe('#rawtransaction', () => {
         console.log(`result: ${util.inspect(result)}`)
         assert.equal(true, false, 'Unexpected result!')
       } catch (err) {
-        assert.hasAnyKeys(err, ['error'])
-        assert.include(err.error, 'Array too large')
+        assert.include(err.message, 'Array too large')
       }
     })
   })

test/integration/util.js

@@ -18,7 +18,7 @@ util.inspect.defaultOptions = {
 
 describe('#util', () => {
   beforeEach(async () => {
-    if (process.env.IS_USING_FREE_TIER) await sleep(1000)
+    if (process.env.IS_USING_FREE_TIER) await sleep(1500)
   })
 
   describe('#validateAddress', () => {

test/unit/slp-utils.js

@@ -2281,23 +2281,25 @@ describe('#SLP Utils', () => {
       assert.equal(result, true)
     })
 
-    it('catches and throws an error', async () => {
-      try {
-        const txid = 'fakeTxid'
-
-        // Force an error
-        sandbox
-          .stub(uut.Utils, 'validateTxid3')
-          .rejects(new Error('fake error'))
-
-        await await uut.Utils.waterfallValidateTxid(txid)
-
-        assert.fail('Unexpected result')
-      } catch (err) {
-        // console.log(`err.message: ${err.message}`)
-        assert.include(err.message, 'fake error')
-      }
-    })
+    // CT 08-09-21 Changed behavior. validateTxid3() is now wrapped in a
+    // try/catch statement that exits quietly if there is an error.
+    // it('catches and throws an error', async () => {
+    //   try {
+    //     const txid = 'fakeTxid'
+    //
+    //     // Force an error
+    //     sandbox
+    //       .stub(uut.Utils, 'validateTxid3')
+    //       .rejects(new Error('fake error'))
+    //
+    //     await await uut.Utils.waterfallValidateTxid(txid)
+    //
+    //     assert.fail('Unexpected result')
+    //   } catch (err) {
+    //     // console.log(`err.message: ${err.message}`)
+    //     assert.include(err.message, 'fake error')
+    //   }
+    // })
   })
 
   describe('#getWhitelist', () => {