Merge pull request #53 from Permissionless-Software-Foundation/dh-profile-todos

feat(nostr): Completed profile feed TODOs

src/components/app-body/nostr/content-creators/content-creators-list.js

@@ -31,9 +31,12 @@ function ContentCreators (props) {
 
   const [followList, setFollowList] = useState([])
 
+  // Get the list of profiles followed by the user.
+  // It aggregates all the followers from all the relays.
   const getFollowList = useCallback(async () => {
     const list = await new Promise((resolve, reject) => {
       let list = []
+      let closedRelays = 0
       const { nostrKeyPair } = appData.bchWalletState
 
       const pool = RelayPool(config.nostrRelays)
@@ -43,49 +46,62 @@ function ContentCreators (props) {
       })
 
       pool.on('eose', relay => {
-        console.log('Closing Relay')
         relay.close()
-        /** This ensures to return an empty array if no records are found!
-         *  Applies for new users that don't have a follow list
-        */
-        resolve(list)
+        closedRelays++
+        // Resolve list if all relays are closed
+        if (closedRelays === config.nostrRelays.length) {
+          resolve(list)
+        }
       })
 
       pool.on('event', (relay, subId, ev) => {
-        console.log('Received event:', ev)
-        list = ev.tags
-        resolve(list)
+        // console.log('Received event:', ev)
+        // Merge list received from all relays
+        list = [...list, ...ev.tags]
       })
     })
 
-    console.log('Follow List', list)
+    // console.log('Follow List', list)
     setFollowList(list)
   }, [appData])
 
+  // Load profile from nostr relays
+  // It uses multiple relays. It will exit after the first successful retrieval
+  // from any relay. If one relay fails, it will move on to the next one.
   const loadProfile = useCallback(async (pubKey) => {
-    return new Promise((resolve) => {
-      // const pool = RelayPool(config.nostrRelays)
-      const pool = RelayPool([config.nostrRelay])
-      pool.on('open', relay => {
-        relay.subscribe('subid', { limit: 5, kinds: [0], authors: [pubKey] })
-      })
+    // Looking for the profile in each relay sequentially
+    for (let i = 0; i < config.nostrRelays.length; i++) {
+      const profile = await new Promise((resolve) => {
+        const relay = config.nostrRelays[i]
+        // const pool = RelayPool(config.nostrRelays)
+        const pool = RelayPool([relay])
+        pool.on('open', relay => {
+          relay.subscribe('subid', { limit: 5, kinds: [0], authors: [pubKey] })
+        })
 
-      pool.on('eose', relay => {
-        console.log('Closing Relay')
-        relay.close()
-        resolve(false)
-      })
-
-      pool.on('event', (relay, subId, ev) => {
-        try {
-          const profile = JSON.parse(ev.content)
-          // console.log('profile', profile)
-          resolve(profile)
-        } catch (error) {
+        pool.on('eose', relay => {
+          console.log('Closing Relay')
+          relay.close()
           resolve(false)
-        }
+        })
+
+        pool.on('event', (relay, subId, ev) => {
+          try {
+            const profile = JSON.parse(ev.content)
+            // console.log('profile', profile)
+            console.log(`Profile found  for ${pubKey} at ${relay.url}`)
+            resolve(profile)
+          } catch (error) {
+            resolve(false)
+          }
+          relay.close()
+        })
       })
-    })
+      // Stop looking for profile if found
+      if (profile) {
+        return profile
+      }
+    }
   }, [])
 
   useEffect(() => {

src/components/app-body/nostr/feeds/feed-card.js

@@ -1,6 +1,7 @@
 /**
  * Component for displaying nostr posts
  */
+
 // Global npm libraries
 import React, { useCallback, useEffect, useState } from 'react'
 import { Card, Spinner } from 'react-bootstrap'
@@ -8,12 +9,15 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
 import { faUser, faHeart as faHeartSolid } from '@fortawesome/free-solid-svg-icons'
 import { faHeart } from '@fortawesome/free-regular-svg-icons'
 import * as nip19 from 'nostr-tools/nip19'
-import NostrFormat from '../nostr-format'
 import { finalizeEvent } from 'nostr-tools/pure'
 import { Relay } from 'nostr-tools/relay'
 import { hexToBytes } from '@noble/hashes/utils' // already an installed dependency
 import { RelayPool } from 'nostr'
 
+// Local libraries
+import CopyOnClick from '../../bch-wallet/copy-on-click.js'
+import NostrFormat from '../nostr-format'
+
 function FeedCard (props) {
   const { post, appData, profiles } = props
   const { nostrKeyPair } = appData.bchWalletState
@@ -21,7 +25,6 @@ function FeedCard (props) {
   const [profile, setProfile] = useState(profiles[post.pubkey])
 
   const [npub, setNpub] = useState('')
-  const [isClicked, setIsClicked] = useState(false)
   const [isLiked, setIsLiked] = useState(false)
   const [likesCount, setLikesCount] = useState(null)
   const [likesFetched, setLikesFetched] = useState(false)
@@ -104,13 +107,6 @@ function FeedCard (props) {
     }
   }, [profiles, post])
 
-  // copy to clipboard
-  const copyToClipboard = useCallback((value) => {
-    setIsClicked(true)
-    appData.appUtil.copyToClipboard(value)
-    setTimeout(() => setIsClicked(false), 200)
-  }, [appData])
-
   // get short npub
   const getShortNpub = useCallback((npub) => {
     return npub.slice(0, 8) + '...' + npub.slice(-5)
@@ -168,6 +164,11 @@ function FeedCard (props) {
     }
   }
 
+  const goToProfile = () => {
+    const profileUrl = `${window.location.origin}/profile/${npub}#single-view`
+    window.open(profileUrl, '_blank')
+  }
+
   return (
     <Card className='mb-4 bg-light rounded-4 shadow-sm border-0'>
       <Card.Body className='p-3'>
@@ -186,20 +187,21 @@ function FeedCard (props) {
                   src={profile.picture}
                   alt='Profile'
                   className='rounded-circle w-100 h-100'
-                  style={{ objectFit: 'cover' }}
+                  style={{ objectFit: 'cover', cursor: 'pointer' }}
                   onError={handleProfilePictureError}
                   onLoad={handleProfilePictureLoad}
+                  onClick={goToProfile}
                 />
                 )
               : (
-                <FontAwesomeIcon icon={faUser} size='1x' color='#7c7c7d' />
+                <FontAwesomeIcon icon={faUser} size='1x' color='#7c7c7d' style={{ cursor: 'pointer' }} onClick={goToProfile} />
                 )}
           </div>
           <div className='flex-grow-1'>
             <div className='fw-bold mb-1'>
-              {profile && profile.name && <span>{profile.name}</span>}
+              {profile && profile.name && <span style={{ cursor: 'pointer' }} onClick={goToProfile}>{profile.name}</span>}
               {!profile?.name && (
-                <span>
+                <span style={{ cursor: 'pointer' }} onClick={goToProfile}>
                   {post.pubkey.slice(0, 8) + '...'}
                   {!profile?.loaded && <Spinner animation='border' size='sm' className='ms-2' />}
                 </span>
@@ -211,14 +213,20 @@ function FeedCard (props) {
                   title='Copy to clipboard'
                   style={{
                     cursor: 'pointer',
-                    transform: isClicked ? 'scale(0.95)' : 'scale(1)',
                     transition: 'transform 0.1s ease',
-                    display: 'inline-block'
+                    display: 'inline-block',
+                    marginRight: '5px'
                   }}
-                  onClick={() => copyToClipboard(npub)}
+                  onClick={goToProfile}
+
                 >
                   {getShortNpub(npub)}
                 </span>
+                <CopyOnClick
+                  walletProp='npub'
+                  appData={props.appData}
+                  value={npub}
+                />
               </small>
             )}
           </div>

src/components/app-body/nostr/feeds/index.js

@@ -1,16 +1,5 @@
 /*
   Component for reading the nostr feeds.
-
-  TODO:
-  - fetchProfile() should retrieve a profile from multiple relays. If the first relay returns a profile,
-    then that profile can be used and promise resolved. If the first relay returns no profile, the next
-    one should be tried until all relays are exhausted or one returns a profile.
-
-  - useEffect() retrieves the feeds. This should cycle through each relay and posts from each one.
-    Once each relays has been tried, the posts should remove duplicate entries. Finally posts should
-    be sorted by date.
-
-  - Clicking on a profile picture, name, or npub should open the profile for that user in a new tab.
 */
 
 // Global npm libraries
@@ -27,91 +16,121 @@ function Feeds (props) {
   const { appData } = props
   const [activeTab, setActiveTab] = useState(appData.lastFeedTab)
 
-  const { bchWalletState } = appData
   const [posts, setPosts] = useState([])
   const [loaded, setLoaded] = useState(false)
   const [profiles, setProfiles] = useState({})
 
-  // function to fetch profile and set it to profiles state
-  const fetchProfile = useCallback(async (pubkey) => {
-    // no fetch profile again if it exist
-    let hasProfileRequest = false
-    setProfiles(currentProfiles => {
-      if (currentProfiles[pubkey]) {
-        hasProfileRequest = true
-        return currentProfiles
-      } else {
-        const newProfiles = { ...currentProfiles }
-        newProfiles[pubkey] = { loaded: false }
-        return newProfiles
-      }
-    })
-    if (hasProfileRequest) return
+  // Load profile from nostr relays
+  // It uses multiple relays. It will exit after the first successful retrieval
+  // from any relay. If one relay fails, it will move on to the next one.
+  const fetchProfile = useCallback(async (pubKey) => {
+    // Looking for the profile in each relay sequentially
+    for (let i = 0; i < config.nostrRelays.length; i++) {
+      const profile = await new Promise((resolve) => {
+        const relay = config.nostrRelays[i]
+        // const pool = RelayPool(config.nostrRelays)
+        const pool = RelayPool([relay])
+        pool.on('open', relay => {
+          relay.subscribe('subid', { limit: 5, kinds: [0], authors: [pubKey] })
+        })
 
-    // const pool = RelayPool(config.nostrRelays)
-    const pool = RelayPool([config.nostrRelay])
-    pool.on('open', relay => {
-      relay.subscribe('subid', { limit: 5, kinds: [0], authors: [pubkey] })
-    })
+        pool.on('eose', relay => {
+          console.log('Closing Relay')
+          relay.close()
+          resolve(false)
+        })
 
-    pool.on('eose', relay => {
-      relay.close()
-      try {
-      // Mark unknown profiles. From this way we can know which profile was fetched and not found.
-        setProfiles(currentProfiles => {
-          if (!currentProfiles[pubkey]) {
-            const newProfiles = { ...currentProfiles }
-            newProfiles[pubkey] = { loaded: true }
-            return newProfiles
+        pool.on('event', (relay, subId, ev) => {
+          try {
+            const profile = JSON.parse(ev.content)
+            // console.log('profile', profile)
+            console.log(`Profile found  for ${pubKey} at ${relay.url}`)
+            resolve(profile)
+          } catch (error) {
+            resolve(false)
           }
-          return currentProfiles
+          relay.close()
         })
-      } catch (error) {
-        console.warn(error)
-        // skip error
+      })
+      // Stop looking for profile if found
+      if (profile) {
+        return profile
       }
-    })
-
-    pool.on('event', (relay, subId, ev) => {
-      try {
-        // update profiles data
-        const profile = JSON.parse(ev.content)
-        setProfiles(currentProfiles => {
-          const newProfiles = { ...currentProfiles }
-          newProfiles[pubkey] = profile
-          return newProfiles
-        })
-      } catch (error) {
-        // skip error
-      }
-    })
+    }
   }, [])
 
-  // Get global feed posts
-  useEffect(() => {
-    const start = () => {
-      // const pool = RelayPool(config.nostrRelays)
-      const pool = RelayPool([config.nostrRelay])
+  // Get array of feeds from relays
+  const fetchFeeds = useCallback(async () => {
+    let feeds = await new Promise((resolve, reject) => {
+      let list = []
+      let closedRelays = 0
+
+      const pool = RelayPool(config.nostrRelays)
+      // const pool = RelayPool([config.nostrRelay])
       pool.on('open', relay => {
         relay.subscribe('REQ', { limit: 10, kinds: [1], '#t': ['slpdex-socialmedia'] })
       })
 
       pool.on('eose', relay => {
-        setLoaded(true)
         relay.close()
+        closedRelays++
+        // Resolve list if all relays are closed
+        if (closedRelays === config.nostrRelays.length) {
+          resolve(list)
+        }
       })
 
-      pool.on('event', async (relay, subId, ev) => {
-        setPosts(currentPosts => [...currentPosts, ev])
-        // fetch post profile and set it to profiles state
-        fetchProfile(ev.pubkey)
+      pool.on('event', (relay, subId, ev) => {
+        // console.log('post retrieved from ', relay.url, ev.sig)
+        list = [...list, ev]
       })
+    })
+
+    // Remove duplicated feeds
+    feeds = feeds.filter((val, i, list) => {
+      const existingIndex = list.findIndex(value => value.id === val.id)
+      return existingIndex === i
+    })
+
+    // Sort from newest to oldest
+    feeds.sort((a, b) => b.created_at - a.created_at)
+
+    // console.log('feeds', feeds)
+
+    setPosts(feeds)
+    return feeds
+  }, [])
+
+  // Load data on component mount.
+  useEffect(() => {
+    const loadData = async () => {
+      // Get feeds
+      const feeds = await fetchFeeds()
+      setLoaded(true)
+
+      const loadedProfiles = [] // fetched profiles ( this will be used for prevent load the same profile multiple times.)
+      // Map feeds and get feed owner profile.
+      for (let i = 0; i < feeds.length; i++) {
+        const pubKey = feeds[i].pubkey
+
+        const exist = loadedProfiles.find((val) => { return val === pubKey })
+        if (exist) { continue }
+        // Fech profile.
+        const profile = await fetchProfile(pubKey)
+        loadedProfiles.push(pubKey) // mark as loaded
+
+        // Update profile state
+        setProfiles(currentProfiles => {
+          const newProfiles = { ...currentProfiles }
+          newProfiles[pubKey] = profile
+          return newProfiles
+        })
+      }
     }
-
     if (!loaded) {
-      start()
+      loadData()
     }
-  }, [bchWalletState, loaded, fetchProfile])
+  }, [loaded, fetchFeeds, fetchProfile])
 
   const onChangeTab = (tab) => {
     setActiveTab(tab)

src/components/app-body/nostr/profile/index.js

@@ -17,7 +17,7 @@ function Profile (props) {
   return (
     <>
       <Container>
-        <ProfileRead {...props} setProfile={setProfile} npub={npub} />
+        <ProfileRead {...props} onProfileRead={setProfile} npub={npub} />
         <PublicRead {...props} profile={profile} npub={npub} />
         <SlpTokensDisplay {...props} npub={npub} />
         <NFTForSale {...props} npub={npub} />

src/components/app-body/nostr/profile/profile-read.js

@@ -1,13 +1,10 @@
 /**
  * Component to read nostr information kind 0 (normal posts)
  *
- * TODO:
- * - Currently feeds are retrieved from only one relay. It should retrieve Kind
- *   0 posts from all relays. It should then remove any duplicate entries.
  */
 
 // Global npm libraries
-import React, { useEffect, useState } from 'react'
+import React, { useEffect, useState, useCallback } from 'react'
 import { Container, Button } from 'react-bootstrap'
 import CopyOnClick from '../../bch-wallet/copy-on-click.js'
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
@@ -21,47 +18,66 @@ import { RelayPool } from 'nostr'
 
 function ProfileRead (props) {
   const { npub } = props
-  const { setProfile } = props
-  const [post, setPost] = useState({})
+  const { onProfileRead } = props
+  const [profile, setProfile] = useState({})
   const [loaded, setLoaded] = useState(false)
   const [imageError, setImageError] = useState({ picture: false, banner: false })
 
+  // Load profile from nostr relays
+  // It uses multiple relays. It will exit after the first successful retrieval
+  // from any relay. If one relay fails, it will move on to the next one.
+  const fetchProfile = useCallback(async (pubKey) => {
+    console.log('fetching profile for pubkey ', pubKey)
+    // Looking for the profile in each relay sequentially
+    for (let i = 0; i < config.nostrRelays.length; i++) {
+      const profile = await new Promise((resolve) => {
+        const relay = config.nostrRelays[i]
+        // const pool = RelayPool(config.nostrRelays)
+        const pool = RelayPool([relay])
+        pool.on('open', relay => {
+          relay.subscribe('subid', { limit: 5, kinds: [0], authors: [pubKey] })
+        })
+
+        pool.on('eose', relay => {
+          console.log('Closing Relay')
+          relay.close()
+          resolve(false)
+        })
+
+        pool.on('event', (relay, subId, ev) => {
+          try {
+            const profile = JSON.parse(ev.content)
+            // console.log('profile', profile)
+            console.log(`Profile found  for ${pubKey} at ${relay.url}`)
+            resolve(profile)
+          } catch (error) {
+            resolve(false)
+          }
+          relay.close()
+        })
+      })
+      // Stop looking for profile if found
+      if (profile) {
+        return profile
+      }
+    }
+  }, [])
+
   useEffect(() => {
-    const start = () => {
+    const start = async () => {
       const pubHexData = nip19.decode(npub)
       const pubHex = pubHexData.data
 
-      // const pool = RelayPool(config.nostrRelays)
-      const pool = new RelayPool([config.nostrRelay])
-      pool.on('open', relay => {
-        relay.subscribe('subid', { limit: 5, kinds: [0], authors: [pubHex] })
-        setLoaded(true)
-      })
-
-      pool.on('eose', relay => {
-        console.log('Closing Relay')
-        relay.close()
-      })
-
-      pool.on('event', (relay, subId, ev) => {
-        console.log('Received event:', ev)
-        try {
-          const profile = JSON.parse(ev.content)
-          console.log('Profile:', profile)
-          setPost(profile)
-          setProfile(profile)
-        } catch (error) {
-          console.error('Error parsing profile:', error)
-        }
-      })
-
+      const profile = await fetchProfile(pubHex)
+      onProfileRead(profile)
+      setProfile(profile)
       setLoaded(true)
     }
 
     if (!loaded && npub) {
       start()
     }
-  }, [loaded, setProfile, npub])
+  }, [loaded, onProfileRead, npub, fetchProfile])
 
   const handleImageError = (type) => {
     setImageError(prev => ({ ...prev, [type]: true }))
@@ -74,10 +90,10 @@ function ProfileRead (props) {
   return (
     <Container>
       {/* Banner Section */}
-      {post.banner && !imageError.banner && (
+      {profile.banner && !imageError.banner && (
         <div className='position-relative'>
           <img
-            src={post.banner}
+            src={profile.banner}
             alt='Profile banner'
             className='w-100 rounded-4 shadow-sm'
             style={{ height: '200px', objectFit: 'cover' }}
@@ -90,10 +106,10 @@ function ProfileRead (props) {
       <div className='d-flex flex-column flex-md-row align-items-center gap-4 mb-5 p-3 p-md-5 bg-light rounded-4 shadow-sm'>
         {/* Profile Picture */}
         <div style={{ width: '120px', height: '120px' }} className='mb-3 mb-md-0'>
-          {post.picture && !imageError.picture
+          {profile.picture && !imageError.picture
             ? (
               <img
-                src={post.picture}
+                src={profile.picture}
                 alt='Profile'
                 className='rounded-circle shadow w-100 h-100'
                 style={{ objectFit: 'cover' }}
@@ -117,7 +133,7 @@ function ProfileRead (props) {
 
         {/* Profile Information */}
         <div className='flex-grow-1 text-center text-md-start mb-3 mb-md-0 d-flex flex-column align-items-center align-items-md-start'>
-          <h3 className='mb-2 fw-bold'>{post.name || 'username'}</h3>
+          <h3 className='mb-2 fw-bold'>{profile.name || 'username'}</h3>
 
           <div className='text-muted small mb-3 d-flex align-items-center flex-column flex-md-row'>
             <span className='text-truncate me-2 mb-2 mb-md-0'>
@@ -132,24 +148,24 @@ function ProfileRead (props) {
           </div>
 
           {/* About Section */}
-          {post.about && (
+          {profile.about && (
             <div className='fs-6 text-secondary'>
-              <NostrFormat content={post.about} />
+              <NostrFormat content={profile.about} />
             </div>
           )}
 
           {/* Website Link */}
-          {post.website && (
+          {profile.website && (
             <div className='mb-3 d-flex align-items-center gap-2'>
               <FontAwesomeIcon icon={faGlobe} className='text-muted' size='sm' />
               <a
-                href={post.website.startsWith('http') ? post.website : `https://${post.website}`}
+                href={profile.website.startsWith('http') ? profile.website : `https://${profile.website}`}
                 target='_blank'
                 rel='noopener noreferrer'
                 className='text-decoration-none text-muted small'
                 style={{ wordBreak: 'break-all' }}
               >
-                {post.website}
+                {profile.website}
               </a>
             </div>
           )}

src/components/app-body/nostr/profile/public-read.js

@@ -2,7 +2,7 @@
  *  Component for read nostr information kind 1
  */
 // Global npm libraries
-import React, { useEffect, useState } from 'react'
+import React, { useEffect, useState, useCallback } from 'react'
 import { Container, Card, Spinner } from 'react-bootstrap'
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
 import { faUser } from '@fortawesome/free-solid-svg-icons'
@@ -20,35 +20,60 @@ function PublicRead (props) {
   const [loaded, setLoaded] = useState(false)
   const [profilePictureError, setProfilePictureError] = useState(false)
 
-  useEffect(() => {
-    // Get Last post from a author
-    const start = () => {
+  const getUserFeeds = useCallback(async () => {
+    let feeds = await new Promise((resolve) => {
+      let list = []
+      let closedRelays = 0
       const pubHexData = nip19.decode(npub)
       const pubHex = pubHexData.data
       console.log('pubhex', pubHex)
 
       const pool = RelayPool(config.nostrRelays)
+
       pool.on('open', relay => {
         relay.subscribe('subid', { limit: 5, kinds: [1], authors: [pubHex] })
-        setLoaded(true)
       })
 
       pool.on('eose', relay => {
         console.log('Closing Relay')
-        setLoaded(true)
         relay.close()
+        closedRelays++
+        // Resolve list if all relays are closed
+        if (closedRelays === config.nostrRelays.length) {
+          resolve(list)
+        }
       })
 
       pool.on('event', (relay, subId, ev) => {
         console.log('Received event:', ev)
-        setPosts(currentPosts => [...currentPosts, ev])
+        list = [...list, ev]
       })
+    })
+    console.log('feeds', feeds)
+    // Remove duplicated feeds
+    feeds = feeds.filter((val, i, list) => {
+      const existingIndex = list.findIndex(value => value.id === val.id)
+      return existingIndex === i
+    })
+
+    // Sort from newest to oldest
+    feeds.sort((a, b) => b.created_at - a.created_at)
+
+    setPosts(feeds)
+  }, [npub])
+
+  useEffect(() => {
+    // Get Last post from a author
+    const start = async () => {
+      setLoaded(true)
+      await getUserFeeds()
+      setLoaded(false)
     }
 
     if (!loaded && npub) {
       start()
     }
-  }, [bchWalletState, loaded, npub])
+  }, [bchWalletState, loaded, npub, getUserFeeds])
 
   const handleProfilePictureError = () => {
     setProfilePictureError(true)