mirror of
https://github.com/Permissionless-Software-Foundation/psf-memo.git
synced 2026-09-21 16:52:01 -07:00
Chris Troutner
1ff2c020ac
Encapsulate the postChildren prefix scan in PostQuery.listChildTxids and have GetPostThread depend only on the PostQuery interface (listChildTxids, getPostOrNull). countRepliesForTxids now reuses listChildTxids. Remove the dead whole-database buildLikeCountMap that this task made obsolete. Cover the prefix-scan guards and cycle back-edge, realign the thread property tests to the adapter seam, and refresh mutation/Gherkin-acceptance manifests. By architect.
32 lines
1.8 KiB
Gherkin
32 lines
1.8 KiB
Gherkin
# acceptance-mutation-manifest-begin
|
|
# {"version":1,"tested_at":"2026-09-15T20:05:07.042976100Z","feature_name":"Thread query performance","feature_path":"/home/trout/work/psf-memo/.worktrees/architect/psf-memo-db/specs/thread-query-performance.feature","background_hash":"e0defd91132ae900d79c841fc5ebe05d91f6bd154a763b742a951e6d5c3626fe","implementation_hash":"sha256:f7082c686e63a5297f4d1964224d7256faf59f5eea13e9f6de4d73ad6401a2ed","scenarios":[]}
|
|
# acceptance-mutation-manifest-end
|
|
|
|
# Scenarios: Thread query performance - 1
|
|
#
|
|
# GET /posts/:txid/thread currently does work proportional to the whole
|
|
# database, not to the requested thread:
|
|
# - get-post-thread.js calls buildLikeCountMap(), which iterates every
|
|
# postLikes entry and loads one post per like just to compute counts.
|
|
# - get-post-thread.js loadChildTxids() iterates every postChildren entry
|
|
# for each node in the thread instead of prefix-scanning that node's
|
|
# parent key.
|
|
# This feature pins the endpoint to bounded, per-thread reads. Thread shape,
|
|
# reply ordering, and per-node likeCount remain specified by like-counts.feature.
|
|
Feature: Thread query performance
|
|
|
|
Background:
|
|
Given a psf-memo-db instance with posts, postHeights, addrPostHeights, postChildren, likes, and postLikes stores
|
|
Given the fixture "posts-with-likes" is loaded into the posts and likes stores
|
|
|
|
Scenario Outline: Thread query performance - 1 GET /posts/:txid/thread performs work bounded by the thread
|
|
When the client requests the thread for <txid>
|
|
Then the post with txid <txid> has likeCount <likeCount>
|
|
And the postChildren store was read at most <max_entries> entries
|
|
And no more than <limit> posts are loaded by txid
|
|
|
|
Examples:
|
|
| txid | likeCount | max_entries | limit |
|
|
| post-200-a | 2 | 1 | 2 |
|
|
| post-200-b | 1 | 0 | 1 |
|