diff --git a/specifier-prompt.md b/specifier-prompt.md index 6307252..9e8ba73 100644 --- a/specifier-prompt.md +++ b/specifier-prompt.md @@ -553,6 +553,33 @@ that a single user-facing feature may require specs in more than one component. inside the same relative-time bucket survive. Tighten only if a future spec needs those fields asserted independently. +41. **Notification entry display: most soft Gherkin survivors are intrinsic.** + For `psf-memo-client/specs/notification-entry-display.feature` the soft + mutation run was 36 total / 11 killed / 25 survived, 0 errors. Every + survivor is a single-character case mutation of an example value (`addr`, + `name`, `avatar`, `my_post`, `reply_text`, `follower`) used on both the + Given setup and the Then assertion side, so the mutated value still matches + (gotcha #12 class). The independently-tied scenarios carried all kills: + scenario 2 compares the avatar/display-name link to an independent + `profile_path`, and scenarios 6/8 compare the fallback name to an + independent truncated-address literal, which pins profile-link encoding and + address truncation. The tool-written manifest contains only scenario 2 + because the others each have an intrinsic survivor; commit it as-is. +42. **Client internal links must navigate via the router.** The architect found + the new `NotificationEntry` rendered profile links as bare anchors; a + bare-anchor click does a full page reload, which breaks the GitHub Pages + deployment (no `404.html` fallback). The wrapper now passes + `onProfileClick={navigate}` (from `useNavigate()`) and the component calls + `event.preventDefault()`. Use `Link`/`useNavigate` for any new internal + client navigation. +43. **Profile-path construction is duplicated across the client.** + `notification-entry.js` exports `PROFILE_PATH_PREFIX`/`profilePath`, while + `profile-page.js` already exports `PROFILE_PATH_PREFIX` and several + components inline `` `/profile/${encodeURIComponent(addr)}` ``. The architect + accepted this as-is and logged a shared `profile-path` module as a + cross-module client-consistency follow-up (`dry4javascript` found no + duplicate candidates in the changed set). + --- ## 10. Run / verify the app @@ -603,17 +630,20 @@ At the end of each session, update this file: - Note the current `master` HEAD commit. - State the next feature to work on. -Current `master` HEAD: `1e58b5b` (`topics-table-layout` merged from +Current `master` HEAD: `a1e4a4f95f` (`notification-entry-display` merged from `swarmforge-architect`). The verification record names the architect code -review commit `d1f0f76`; the only later commit (`1e58b5b`) added `docs/` +review commit `bbbf4adcd7`; the only later commit (`a1e4a4f`) added `docs/` (record and summary), so the record is valid for the merged tree. This task -replaced the topics page flexbox rows with a react-bootstrap `Table` driven by -a pure `buildTopicsTable` view model -(`psf-memo-client/src/services/topics-table.js`). Record: -`docs/reviews/topics-table-layout-verification.json` (client). The specifier -merged the branch and ran only the merged feature's acceptance test (client -5/5) as the independent check; soft Gherkin mutation was 16/16 killed and -language mutation 2/2 killed. Run `swarmforge/scripts/state.sh` to refresh +renders each Notifications entry with the actor's resolved Memo display name +and avatar (truncated-address / identicon fallbacks), router profile links on +the avatar and name, the full address as small plain text, and a "View Post" +link for like/reply entries that opens the referenced post's thread. Pure view +model `psf-memo-client/src/services/notification-entry.js`; record +`docs/reviews/notification-entry-display-verification.json` (client). The +specifier merged the branch and ran only the merged feature's acceptance test +(client 16/16) as the independent check; soft Gherkin mutation was 36/11 (all +survivors intrinsic example-value case mutations; scenario 2 killed 4/4) and +language mutation 20/20 killed. Run `swarmforge/scripts/state.sh` to refresh these HEAD lines. Next action: **TBD** — ask the user for the next feature. Current direction is front-end improvements to `psf-memo-client` (UI/UX polish, accessibility, diff --git a/specs/feature-backlog.md b/specs/feature-backlog.md index c16f137..3019945 100644 --- a/specs/feature-backlog.md +++ b/specs/feature-backlog.md @@ -35,6 +35,23 @@ _(none)_ ## Recently completed +- **Notification entry display (2026-09-18):** each `/notifications` entry now + shows the actor's Memo display name and avatar instead of only the raw BCH + address, resolved client-side from the name and profile-picture records. The + avatar and display name link to `/profile/`, the full address renders as + small non-emphasised plain text, and like/reply entries carry a "View Post" + link that opens the referenced original post's thread modal. Follow entries + have no post link. Fallbacks: no display name shows the truncated address, no + avatar (or a failed profile lookup) shows an identicon. Client-only. Spec: + `psf-memo-client/specs/notification-entry-display.feature`. Merged to `master` + at `a1e4a4f95f` (review commit `bbbf4adcd7`; record + `docs/reviews/notification-entry-display-verification.json`; the later + `a1e4a4f` commit is docs-only, so the record is valid for the merged tree). + Independent acceptance check: client 16/16. Soft Gherkin mutation 36/11 (all + survivors intrinsic example-value case mutations); language mutation 20/20 + killed. Architect summary: + `docs/reviews/notification-entry-display-summary.md`. + - **Notifications query performance (2026-09-18):** `GET /posts/notifications/:addr` is now bounded to the viewer's activity inside a configurable block window (`NOTIFICATION_BLOCK_WINDOW`, default 25000; cutoff