Remove unnecesary error catching

This commit is contained in:
Adrian Obelmejias
2016-02-15 16:30:49 -05:00
parent 6f34ecf76a
commit f3172adf77
+21 -36
View File
@@ -7,26 +7,19 @@ const router = new Router({ prefix: '/users' })
router.get('/', router.get('/',
async (ctx) => { async (ctx) => {
try { const users = User.find({}, '-password -salt')
const users = User.find({}, '-password -salt') ctx.body = users
ctx.body = users
} catch (err) {
this.throw(err, 500)
}
} }
) )
router.get('/:id', router.get('/:id',
async (ctx) => { async (ctx) => {
try { const user = await User.findById(ctx.params.id, '-password -salt')
const user = await User.findById(ctx.params.id, '-password -salt') if (!user) {
if (!user) { ctx.throw(404)
this.throw(404)
}
ctx.body = user
} catch (err) {
this.throw(err, 500)
} }
ctx.body = user
} }
) )
@@ -54,39 +47,31 @@ router.post('/',
router.put('/:id', router.put('/:id',
async (ctx) => { async (ctx) => {
try { const user = await User.findById(ctx.params.id)
const user = await User.findById(ctx.params.id)
if (!user) { if (!user) {
throw new Error({ status: 404 })
}
Object.assign(user, ctx.request.body.user)
await user.save()
ctx.body = 200
} catch (err) {
ctx.throw(404) ctx.throw(404)
} }
Object.assign(user, ctx.request.body.user)
await user.save()
ctx.body = 200
} }
) )
router.delete('/:id', router.delete('/:id',
async (ctx) => { async (ctx) => {
try { const user = await User.findById(ctx.params.id)
const user = await User.findById(ctx.params.id)
if (!user) { if (!user) {
throw new Error({ status: 404 })
}
await user.remove()
ctx.body = 200
} catch (err) {
ctx.throw(404) ctx.throw(404)
} }
await user.remove()
ctx.body = 200
} }
) )