fullstack/bch-api
1
0
Fork 0
mirror of https://github.com/fullstack-cash/bch-api.git synced 2026-09-22 17:22:04 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(error handling): Replacing improper 429 with 400

Browse Source
This commit is contained in:
Chris Troutner
2021-03-08 17:03:44 -08:00
parent a1ce8bf742
commit d38746dcbd
5 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/routes/v4/blockbook.js
+3 -3
View File
@@ -169,7 +169,7 @@ class Blockbook {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -333,7 +333,7 @@ class Blockbook {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -472,7 +472,7 @@ class Blockbook {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, txids)) { if (!_this.routeUtils.validateArraySize(req, txids)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
src/routes/v4/electrumx.js
+6 -6
View File
@@ -284,7 +284,7 @@ class Electrum {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -470,7 +470,7 @@ class Electrum {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, txids)) { if (!_this.routeUtils.validateArraySize(req, txids)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
success: false, success: false,
error: 'Array too large.' error: 'Array too large.'
@@ -726,7 +726,7 @@ class Electrum {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, heights)) { if (!_this.routeUtils.validateArraySize(req, heights)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
success: false, success: false,
error: 'Array too large.' error: 'Array too large.'
@@ -895,7 +895,7 @@ class Electrum {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -1088,7 +1088,7 @@ class Electrum {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -1281,7 +1281,7 @@ class Electrum {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
src/routes/v4/slp.js
+5 -5
View File
@@ -215,7 +215,7 @@ class Slp {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, tokenIds)) { if (!_this.routeUtils.validateArraySize(req, tokenIds)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -545,7 +545,7 @@ class Slp {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -914,7 +914,7 @@ class Slp {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, addresses)) { if (!_this.routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -975,7 +975,7 @@ class Slp {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, txids)) { if (!_this.routeUtils.validateArraySize(req, txids)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
@@ -1403,7 +1403,7 @@ class Slp {
// Enforce array size rate limits // Enforce array size rate limits
if (!_this.routeUtils.validateArraySize(req, txids)) { if (!_this.routeUtils.validateArraySize(req, txids)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
src/routes/v4/util.js
+1 -1
View File
@@ -141,7 +141,7 @@ class UtilRoute {
// Enforce array size rate limits // Enforce array size rate limits
if (!routeUtils.validateArraySize(req, addresses)) { if (!routeUtils.validateArraySize(req, addresses)) {
res.status(429) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330 res.status(400) // https://github.com/Bitcoin-com/rest.bitcoin.com/issues/330
return res.json({ return res.json({
error: 'Array too large.' error: 'Array too large.'
}) })
test/v4/a01-electrumx.js
+4 -4
View File
@@ -594,7 +594,7 @@ describe('#Electrumx', () => {
assert.isArray(result.transactions) assert.isArray(result.transactions)
}) })
it('should throw 429 error if txid array is too large', async () => { it('should throw 400 error if txid array is too large', async () => {
const testArray = [] const testArray = []
for (var i = 0; i < 25; i++) testArray.push('') for (var i = 0; i < 25; i++) testArray.push('')
@@ -603,7 +603,7 @@ describe('#Electrumx', () => {
const result = await electrumxRoute.transactionDetailsBulk(req, res) const result = await electrumxRoute.transactionDetailsBulk(req, res)
// console.log(`result: ${util.inspect(result)}`) // console.log(`result: ${util.inspect(result)}`)
expectRouteError(res, result, 'Array too large', 429) expectRouteError(res, result, 'Array too large', 400)
}) })
it('should get details for a single txid', async () => { it('should get details for a single txid', async () => {
@@ -841,7 +841,7 @@ describe('#Electrumx', () => {
assert.isArray(result.headers) assert.isArray(result.headers)
}) })
it('should throw 429 error if heights array is too large', async () => { it('should throw 400 error if heights array is too large', async () => {
const testArray = [] const testArray = []
for (var i = 0; i < 25; i++) testArray.push('') for (var i = 0; i < 25; i++) testArray.push('')
@@ -849,7 +849,7 @@ describe('#Electrumx', () => {
const result = await electrumxRoute.blockHeadersBulk(req, res) const result = await electrumxRoute.blockHeadersBulk(req, res)
expectRouteError(res, result, 'Array too large', 429) expectRouteError(res, result, 'Array too large', 400)
}) })
it('should get details for a single height', async () => { it('should get details for a single height', async () => {