mirror of
https://github.com/fullstack-cash/bch-api.git
synced 2026-09-22 17:22:04 -07:00
fix(rate limits): Removing unneeded code
This commit is contained in:
Chris Troutner
@@ -15,7 +15,6 @@ const { mockReq, mockRes, mockNext } = require('./mocks/express-mocks')
|
||||
// Libraries under test
|
||||
const RateLimits = require('../../src/middleware/route-ratelimit')
|
||||
let rateLimits = new RateLimits()
|
||||
let rateLimitMiddleware = rateLimits.routeRateLimit
|
||||
|
||||
// const controlRoute = require('../../src/routes/v3/full-node/control')
|
||||
const jwtAuth = require('../../src/middleware/jwt-auth')
|
||||
@@ -93,169 +92,6 @@ describe('#route-ratelimits & jwt-auth', () => {
|
||||
})
|
||||
})
|
||||
|
||||
describe('#routeRateLimit', () => {
|
||||
rateLimitMiddleware = new RateLimits()
|
||||
let routeRateLimit = rateLimitMiddleware.routeRateLimit
|
||||
// const getInfo = controlRoute.testableComponents.getInfo
|
||||
|
||||
// NOTE: this test will fail if you run multiple integration tests in a
|
||||
// short period. Because it talks to the Redis DB.
|
||||
it('should pass through rate-limit middleware', async () => {
|
||||
req.baseUrl = '/v3'
|
||||
req.path = '/control/getNetworkInfo'
|
||||
req.method = 'GET'
|
||||
|
||||
// Call the route twice to trigger the rate handling.
|
||||
await routeRateLimit(req, res, next)
|
||||
await routeRateLimit(req, res, next)
|
||||
|
||||
// next() will be called if rate-limit is not triggered
|
||||
assert.equal(next.called, true)
|
||||
})
|
||||
|
||||
it('should trigger rate-limit handler if rate limits exceeds 5 request per minute', async () => {
|
||||
req.baseUrl = '/v3'
|
||||
req.path = '/control/getNetworkInfo'
|
||||
req.method = 'GET'
|
||||
|
||||
for (let i = 0; i < 5; i++) {
|
||||
next.reset() // reset the stubbed next() function.
|
||||
|
||||
await routeRateLimit(req, res, next)
|
||||
// console.log(`next() called: ${next.called}`)
|
||||
}
|
||||
|
||||
// Note: next() will be called unless the rate-limit kicks in.
|
||||
assert.equal(
|
||||
next.called,
|
||||
false,
|
||||
'next should not be called if rate limit was triggered.'
|
||||
)
|
||||
})
|
||||
|
||||
it('should NOT trigger rate-limit for free-tier at 5 RPM', async () => {
|
||||
// Clear the require cache before running this test.
|
||||
// delete require.cache[
|
||||
// require.resolve("../../src/middleware/route-ratelimit")
|
||||
// ]
|
||||
// rateLimitMiddleware = require("../../src/middleware/route-ratelimit")
|
||||
rateLimitMiddleware = new RateLimits()
|
||||
routeRateLimit = rateLimitMiddleware.routeRateLimit
|
||||
|
||||
req.baseUrl = '/v3'
|
||||
req.path = '/control/getNetworkInfo'
|
||||
req.method = 'GET'
|
||||
|
||||
req.locals.proLimit = true
|
||||
req.locals.apiLevel = 0
|
||||
|
||||
for (let i = 0; i < 5; i++) {
|
||||
next.reset() // reset the stubbed next() function.
|
||||
|
||||
await routeRateLimit(req, res, next)
|
||||
// console.log(`next() called: ${next.called}`)
|
||||
}
|
||||
|
||||
// console.log(`req.locals after test: ${util.inspect(req.locals)}`)
|
||||
|
||||
// Note: next() will be called unless the rate-limit kicks in.
|
||||
assert.equal(
|
||||
next.called,
|
||||
true,
|
||||
'next should be called if rate limit was not triggered.'
|
||||
)
|
||||
})
|
||||
|
||||
it('should trigger rate-limit for free tier after 10 RPM', async () => {
|
||||
req.baseUrl = '/v3'
|
||||
req.path = '/control/getNetworkInfo'
|
||||
req.method = 'GET'
|
||||
|
||||
req.locals.proLimit = true
|
||||
req.locals.apiLevel = 0
|
||||
|
||||
for (let i = 0; i < 12; i++) {
|
||||
next.reset() // reset the stubbed next() function.
|
||||
|
||||
await routeRateLimit(req, res, next)
|
||||
// console.log(`next() called: ${next.called}`)
|
||||
}
|
||||
|
||||
// Note: next() will be called unless the rate-limit kicks in.
|
||||
assert.equal(
|
||||
next.called,
|
||||
false,
|
||||
'next should not be called if rate limit was triggered.'
|
||||
)
|
||||
})
|
||||
|
||||
it('should NOT trigger rate-limit handler for pro-tier at 25 RPM', async () => {
|
||||
// Clear the require cache before running this test.
|
||||
// delete require.cache[
|
||||
// require.resolve("../../src/middleware/route-ratelimit")
|
||||
// ]
|
||||
// rateLimitMiddleware = require("../../src/middleware/route-ratelimit")
|
||||
rateLimitMiddleware = new RateLimits()
|
||||
routeRateLimit = rateLimitMiddleware.routeRateLimit
|
||||
|
||||
req.baseUrl = '/v3'
|
||||
req.path = '/control/getNetworkInfo'
|
||||
req.method = 'GET'
|
||||
|
||||
req.locals.proLimit = true
|
||||
req.locals.apiLevel = 10
|
||||
|
||||
for (let i = 0; i < 25; i++) {
|
||||
next.reset() // reset the stubbed next() function.
|
||||
|
||||
await routeRateLimit(req, res, next)
|
||||
// console.log(`next() called: ${next.called}`)
|
||||
}
|
||||
|
||||
// console.log(`req.locals after test: ${util.inspect(req.locals)}`)
|
||||
|
||||
// Note: next() will be called unless the rate-limit kicks in.
|
||||
assert.equal(
|
||||
next.called,
|
||||
true,
|
||||
'next should be called if rate limit was not triggered.'
|
||||
)
|
||||
})
|
||||
|
||||
it('rate-limiting should still kick in at a higher RPM for pro-tier', async () => {
|
||||
// Clear the require cache before running this test.
|
||||
// delete require.cache[
|
||||
// require.resolve("../../src/middleware/route-ratelimit")
|
||||
// ]
|
||||
// rateLimitMiddleware = require("../../src/middleware/route-ratelimit")
|
||||
rateLimitMiddleware = new RateLimits()
|
||||
routeRateLimit = rateLimitMiddleware.routeRateLimit
|
||||
|
||||
req.baseUrl = '/v3'
|
||||
req.path = '/control/getNetworkInfo'
|
||||
req.method = 'GET'
|
||||
|
||||
req.locals.proLimit = true
|
||||
req.locals.apiLevel = 10
|
||||
|
||||
for (let i = 0; i < 150; i++) {
|
||||
next.reset() // reset the stubbed next() function.
|
||||
|
||||
await routeRateLimit(req, res, next)
|
||||
// console.log(`next() called: ${next.called}`)
|
||||
}
|
||||
|
||||
// console.log(`req.locals after test: ${util.inspect(req.locals)}`)
|
||||
|
||||
// Note: next() will be called unless the rate-limit kicks in.
|
||||
assert.equal(
|
||||
next.called,
|
||||
false,
|
||||
'next should NOT be called if rate limit was triggered.'
|
||||
)
|
||||
})
|
||||
})
|
||||
|
||||
describe('#getResource', () => {
|
||||
it('should decode a blockchain request', () => {
|
||||
const url =
|
||||
@@ -409,35 +245,6 @@ describe('#route-ratelimits & jwt-auth', () => {
|
||||
})
|
||||
})
|
||||
|
||||
describe('#calcPoints2', () => {
|
||||
it('should return 30 points for anonymous user', () => {
|
||||
const result = rateLimits.calcPoints2({})
|
||||
// console.log(`result: ${result}`)
|
||||
|
||||
assert.equal(result, 30)
|
||||
})
|
||||
|
||||
it('should return 10 point for free tier', () => {
|
||||
const jwtInfo = {
|
||||
rateLimit: 10,
|
||||
id: '5e3a0415eb29a962da2708b4'
|
||||
}
|
||||
|
||||
const result = rateLimits.calcPoints2(jwtInfo)
|
||||
assert.equal(result, 10)
|
||||
})
|
||||
|
||||
it('should return 1 point for pro tier', () => {
|
||||
const jwtInfo = {
|
||||
rateLimit: 100,
|
||||
id: '5e3a0415eb29a962da2708b4'
|
||||
}
|
||||
|
||||
const result = rateLimits.calcPoints2(jwtInfo)
|
||||
assert.equal(result, 1)
|
||||
})
|
||||
})
|
||||
|
||||
describe('#rateLimitByResource', () => {
|
||||
// NOTE: this test will fail if you run multiple integration tests in a
|
||||
// short period. Because it talks to the Redis DB.
|
||||
|
||||
Reference in New Issue
Block a user