From dd7841fd405eac4f582336a59618aa7742d42025 Mon Sep 17 00:00:00 2001 From: Chris Troutner Date: Sat, 12 Oct 2019 14:39:26 -0700 Subject: [PATCH 1/2] fix(rate-limit): Increasing default rate limit to 30 rpm --- src/middleware/route-ratelimit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/middleware/route-ratelimit.js b/src/middleware/route-ratelimit.js index 70eaae6..25aab88 100644 --- a/src/middleware/route-ratelimit.js +++ b/src/middleware/route-ratelimit.js @@ -15,7 +15,7 @@ const RateLimit = require("express-rate-limit") // Set max requests per minute const maxRequests = process.env.RATE_LIMIT_MAX_REQUESTS ? parseInt(process.env.RATE_LIMIT_MAX_REQUESTS) - : 20 + : 30 // Pro-tier rate limits are 10x the freemium limits. const PRO_RPM = 10 * maxRequests From 9ab0e8c52ad4c15fa43813fb9b64f1b571cadbe6 Mon Sep 17 00:00:00 2001 From: Chris Troutner Date: Sat, 12 Oct 2019 15:03:34 -0700 Subject: [PATCH 2/2] Fixing unit tests --- test/v3/rate-limits.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/v3/rate-limits.js b/test/v3/rate-limits.js index 6f84875..4ccb978 100644 --- a/test/v3/rate-limits.js +++ b/test/v3/rate-limits.js @@ -64,7 +64,7 @@ describe("#route-ratelimits", () => { req.path = "/control/getNetworkInfo" req.method = "GET" - for (let i = 0; i < 25; i++) { + for (let i = 0; i < 35; i++) { next.reset() // reset the stubbed next() function. await routeRateLimit(req, res, next) @@ -134,7 +134,7 @@ describe("#route-ratelimits", () => { // Prepare the authorization header //req.headers.authorization = generateAuthHeader("BITBOX") - for (let i = 0; i < 300; i++) { + for (let i = 0; i < 400; i++) { next.reset() // reset the stubbed next() function. await routeRateLimit(req, res, next)